Skip to content

Make mysqlclient an optional dependency#250

Open
willprice wants to merge 4 commits intoclips:masterfrom
uob-vil:master
Open

Make mysqlclient an optional dependency#250
willprice wants to merge 4 commits intoclips:masterfrom
uob-vil:master

Conversation

@willprice
Copy link

@willprice willprice commented Nov 17, 2018

MySQL shouldn't be a core dependency, I've moved it to an extra package which can be installed as pip install pattern[mysql] if users wish to install with mysql support.

@coveralls
Copy link

coveralls commented Nov 17, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 67.472% when pulling 3b77852 on uob-vil:master into 5b85d99 on clips:master.

@willprice willprice mentioned this pull request Nov 21, 2018
Closed
@gutomaia
Copy link

gutomaia commented Feb 18, 2019

+1

1 similar comment
@zh0uquan
Copy link

zh0uquan commented Feb 25, 2019

+1

@kylemcdonald
Copy link

kylemcdonald commented Apr 17, 2019

thank you. i tried to get pattern running on mac with this:

brew install mysql-client
pip3 install pattern

But I couldn't get it to work. This works though:

pip3 install git+https://github.com/uob-vil/pattern.git

@tuky
Copy link

tuky commented Nov 7, 2019

It would be awesome to see this happen! :-)

This was referenced Jan 21, 2021
Open
Open
Open
Open
@Sjoerd82
Copy link

Sjoerd82 commented Jan 21, 2021

Mysql really complicates the installation, as it turns out installing the myssqlclient on a windows machine is non trivial. Any luck on removing this dependency? I've linked some related issues which can all be closed when this is resolved.

@ndvbd
Copy link

ndvbd commented Dec 5, 2022

I get:

File "/usr/lib/python3.10/zipfile.py", line 1267, in init
self._RealGetContents()
File "/usr/lib/python3.10/zipfile.py", line 1334, in _RealGetContents
raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

@sanmai-NL
Copy link

sanmai-NL commented Feb 10, 2023

@tom-de-smedt Can you please merge this or mark the GitHub project as Archived?

@gokulnath-prabakaran-zoomrx
Copy link

gokulnath-prabakaran-zoomrx commented May 3, 2024

When will this issue be resolved?

@kdmukai kdmukai mentioned this pull request Aug 1, 2024
Merged
kdmukai added a commit to readworks/pattern that referenced this pull request Aug 1, 2024
@kdmukai
Merge pull request #1 from readworks/pr_250
2d7bad2 
Apply upstream's PR clips#250 to "development" branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@willprice @coveralls @gutomaia @zh0uquan @kylemcdonald @tuky @Sjoerd82 @ndvbd @sanmai-NL @gokulnath-prabakaran-zoomrx